Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Download Elastic GPG key during build #134861

Merged
merged 9 commits into from
Jun 23, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jun 21, 2022

Summary

Part of #133822.

Add a build step to add the Elastic GPG key from https://artifacts.elastic.co/GPG-KEY-elasticsearch to the kibana repo at x-pack/plugins/fleet/target/keys.

The location of the key can be overridden by users with the xpack.fleet.packageVerification.gpgKeyPath config item.

Add a function getGpgKeyOrUndefined in the fleet plugin to access the key, in the interest of keeping the PR's small this method isn't currently called but will be in subsequent verification work for 8.4.

Checklist

Delete any items that are not applicable to this PR.

@hop-dev hop-dev force-pushed the 133822-add-public-key-to-repo branch 2 times, most recently from 88ff723 to 22a0119 Compare June 22, 2022 14:38
@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jun 22, 2022
@hop-dev hop-dev changed the title 133822 add public key to repo [Fleet] Download Elastic GPG Key during build Jun 22, 2022
@hop-dev hop-dev changed the title [Fleet] Download Elastic GPG Key during build [Fleet] Download Elastic GPG key during build Jun 22, 2022
@hop-dev hop-dev marked this pull request as ready for review June 22, 2022 14:49
@hop-dev hop-dev requested review from a team as code owners June 22, 2022 14:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev hop-dev force-pushed the 133822-add-public-key-to-repo branch from 3ec07de to 1e2f48d Compare June 23, 2022 09:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1308 1309 +1
Unknown metric groups

API count

id before after diff
fleet 1435 1436 +1

History

  • 💚 Build #52462 succeeded 3ec07debf1132b25c16f35ef53366f3d8a40d765
  • 💚 Build #52348 succeeded 88ff723d4a50ce22e8bd85341caa4ee0612ec9c3
  • 💚 Build #52244 succeeded a84221a5d34b20b93c6794c2f0ead3c66606f35f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev hop-dev merged commit 69caa31 into elastic:main Jun 23, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 23, 2022
@hop-dev hop-dev deleted the 133822-add-public-key-to-repo branch June 23, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants